Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Remove the hard version between Fleet and the Elastic Agent. #17764

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 16, 2020

This removes the check that Kibana was doing to enforce that the remote
version match the current version of Kibana. Instead, the Fleet API
should take the agent header version and ensure we can support it.

This allows the Kibana side to control the communication and the upgrade
more gracefully.

Fixes: #17761

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Test with a snapshot released of the Elastic-Agent.

Related issues

Use cases

Screenshots

Logs

This remove the check that Kibana was doing to enforce that the remove
version match the current version of Kibana. Instead the Fleet API
should take the agent header version and ensure we can support it.

This allow the Kibana side to control the communication and the upgrade
more gracefully.

Fixes: elastic#17761
@ph ph added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Ingest Management labels Apr 16, 2020
@ph ph self-assigned this Apr 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor Author

ph commented Apr 16, 2020

Discussion to move it to a Fleet concern in elastic/kibana#63736

@ph ph changed the title Remove the hard version between Fleet and the Elastic Agent. [Agent] Remove the hard version between Fleet and the Elastic Agent. Apr 16, 2020
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ph ph merged commit c40a841 into elastic:master Apr 17, 2020
@ph ph added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 17, 2020
ph added a commit to ph/beats that referenced this pull request Apr 17, 2020
…lastic#17764)

* Remove the hard version between Fleet and the Elastic Agent.

This remove the check that Kibana was doing to enforce that the remove
version match the current version of Kibana. Instead the Fleet API
should take the agent header version and ensure we can support it.

This allow the Kibana side to control the communication and the upgrade
more gracefully.

Fixes: elastic#17761
(cherry picked from commit c40a841)
ph added a commit that referenced this pull request Apr 20, 2020
…eet and the Elastic Agent. (#17806)

* [Agent] Remove the hard version between Fleet and the Elastic Agent. (#17764)

* Remove the hard version between Fleet and the Elastic Agent.

This remove the check that Kibana was doing to enforce that the remove
version match the current version of Kibana. Instead the Fleet API
should take the agent header version and ensure we can support it.

This allow the Kibana side to control the communication and the upgrade
more gracefully.

Fixes: #17761
(cherry picked from commit c40a841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elastic-agent: running with snapshots of dependencies
3 participants