-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Agent] Remove the hard version between Fleet and the Elastic Agent. #17764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This remove the check that Kibana was doing to enforce that the remove version match the current version of Kibana. Instead the Fleet API should take the agent header version and ensure we can support it. This allow the Kibana side to control the communication and the upgrade more gracefully. Fixes: elastic#17761
ph
added
review
needs_backport
PR is waiting to be backported to other branches.
[zube]: In Review
Team:Ingest Management
labels
Apr 16, 2020
Pinging @elastic/ingest-management (Team:Ingest Management) |
Discussion to move it to a Fleet concern in elastic/kibana#63736 |
ph
changed the title
Remove the hard version between Fleet and the Elastic Agent.
[Agent] Remove the hard version between Fleet and the Elastic Agent.
Apr 16, 2020
michalpristas
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6 tasks
ph
added
v7.8.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Apr 17, 2020
ph
added a commit
to ph/beats
that referenced
this pull request
Apr 17, 2020
…lastic#17764) * Remove the hard version between Fleet and the Elastic Agent. This remove the check that Kibana was doing to enforce that the remove version match the current version of Kibana. Instead the Fleet API should take the agent header version and ensure we can support it. This allow the Kibana side to control the communication and the upgrade more gracefully. Fixes: elastic#17761 (cherry picked from commit c40a841)
6 tasks
ph
added a commit
that referenced
this pull request
Apr 20, 2020
…eet and the Elastic Agent. (#17806) * [Agent] Remove the hard version between Fleet and the Elastic Agent. (#17764) * Remove the hard version between Fleet and the Elastic Agent. This remove the check that Kibana was doing to enforce that the remove version match the current version of Kibana. Instead the Fleet API should take the agent header version and ensure we can support it. This allow the Kibana side to control the communication and the upgrade more gracefully. Fixes: #17761 (cherry picked from commit c40a841)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the check that Kibana was doing to enforce that the remote
version match the current version of Kibana. Instead, the Fleet API
should take the agent header version and ensure we can support it.
This allows the Kibana side to control the communication and the upgrade
more gracefully.
Fixes: #17761
What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Test with a snapshot released of the Elastic-Agent.
Related issues
Use cases
Screenshots
Logs