Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17550 to 7.x: [Filebeat] Improve ECS categorization field mappings for nats module #17755

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Apr 16, 2020

Cherry-pick of PR #17550 to 7.x branch. Original message:

What does this PR do?

Adds ECS categorization fields to nats module.

Why is it important?

ECS categorization fields improve experience in SIEM module and across inputs from different sources.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=nats mage -v pythonIntegTest

Related issues

Closes #16173

…lastic#17550)

* Improve ECS categorization field mappings for nats module

- event.kind
- event.type
- related.ip

Closes elastic#16173

(cherry picked from commit eb5ba9a)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@leehinman leehinman merged commit 4abd25a into elastic:7.x Apr 16, 2020
@leehinman leehinman deleted the backport_17550_7.x branch April 16, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants