Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Agent] added test which covers fleet to router #17746

Merged
merged 3 commits into from
Apr 17, 2020
Merged

[Agent] added test which covers fleet to router #17746

merged 3 commits into from
Apr 17, 2020

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

This test covers flow from raw checkin response to config request to verify we generate monitoring configuration.

Why is it important?

To verify that everything from fleet is parsed correctly

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas force-pushed the agent-add-managed-mode-routing-test branch from 7ad87da to c8a1b55 Compare April 16, 2020 07:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

ph
ph approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding this!

@ph
Copy link
Contributor

ph commented Apr 16, 2020

Looking at he macOS failure this look like a mac worker issue.

@ph ph added needs_backport PR is waiting to be backported to other branches. [zube]: In Review review labels Apr 16, 2020
@michalpristas michalpristas merged commit 15ad134 into elastic:master Apr 17, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Apr 20, 2020
@michalpristas
[Agent] added test which covers fleet to router (elastic#17746)
93c1f5c 
[Agent] added test which covers fleet to router (elastic#17746)

(cherry picked from commit 15ad134)
@michalpristas michalpristas mentioned this pull request Apr 20, 2020
Merged
6 tasks
ph pushed a commit that referenced this pull request Apr 20, 2020
@michalpristas
[Agent] added test which covers fleet to router (#17746) (#17824)
9e224ca 
[Agent] added test which covers fleet to router (#17746)

(cherry picked from commit 15ad134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees
No one assigned
Labels
needs_backport PR is waiting to be backported to other branches. review [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @ph