Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error #17735

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error #17735

merged 3 commits into from
Apr 20, 2020

Conversation

alakahakai
Copy link

Filebeat Httpjson input: Fix issue #17734 to retry on rate-limit error.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@alakahakai
Copy link
Author

Retry for other HTTP errors will be in a separate PR later.

@alakahakai alakahakai added the needs_backport PR is waiting to be backported to other branches. label Apr 15, 2020
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test for the 429 status code. This will help prevent future regressions and demonstrate that the rate limit handling is working as expected.

@alakahakai alakahakai requested a review from andrewkroh April 17, 2020 19:01
@alakahakai alakahakai merged commit bcbabdb into elastic:master Apr 20, 2020
@alakahakai alakahakai added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 20, 2020
alakahakai pushed a commit that referenced this pull request Apr 20, 2020
…o retry on rate-limit error (#17840)

* Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error (#17735)

* Fix issue 17734 to add retry for rate-limit error.

* Add test case for rate-limit error retry.

* Make isRetry a local variable in createCustomServer function.

(cherry picked from commit bcbabdb)

* Fix CHANGELOG.next.asciidoc
alakahakai pushed a commit that referenced this pull request Apr 20, 2020
…or in the Filebeat httpjson input. (#17839)

* Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error (#17735)

* Fix issue 17734 to add retry for rate-limit error.

* Add test case for rate-limit error retry.

* Make isRetry a local variable in createCustomServer function.

(cherry picked from commit bcbabdb)

* Fix CHANGELOG.next.asciidoc
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…mit error in the Filebeat httpjson input. (elastic#17839)

* Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error (elastic#17735)

* Fix issue 17734 to add retry for rate-limit error.

* Add test case for rate-limit error retry.

* Make isRetry a local variable in createCustomServer function.

(cherry picked from commit 85b84c2)

* Fix CHANGELOG.next.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants