-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error #17735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/siem (Team:SIEM) |
Retry for other HTTP errors will be in a separate PR later. |
alakahakai
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Apr 15, 2020
andrewkroh
reviewed
Apr 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test for the 429 status code. This will help prevent future regressions and demonstrate that the rate limit handling is working as expected.
andrewkroh
approved these changes
Apr 20, 2020
alakahakai
added
v7.8.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Apr 20, 2020
alakahakai
pushed a commit
that referenced
this pull request
Apr 20, 2020
…o retry on rate-limit error (#17840) * Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error (#17735) * Fix issue 17734 to add retry for rate-limit error. * Add test case for rate-limit error retry. * Make isRetry a local variable in createCustomServer function. (cherry picked from commit bcbabdb) * Fix CHANGELOG.next.asciidoc
alakahakai
pushed a commit
that referenced
this pull request
Apr 20, 2020
…or in the Filebeat httpjson input. (#17839) * Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error (#17735) * Fix issue 17734 to add retry for rate-limit error. * Add test case for rate-limit error retry. * Make isRetry a local variable in createCustomServer function. (cherry picked from commit bcbabdb) * Fix CHANGELOG.next.asciidoc
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…mit error in the Filebeat httpjson input. (elastic#17839) * Filebeat Httpjson input: Fix issue 17734 to retry on rate-limit error (elastic#17735) * Fix issue 17734 to add retry for rate-limit error. * Add test case for rate-limit error retry. * Make isRetry a local variable in createCustomServer function. (cherry picked from commit 85b84c2) * Fix CHANGELOG.next.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filebeat Httpjson input: Fix issue #17734 to retry on rate-limit error.