Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ECS-compatible deprecation logs emitted by ES 8.0.0+ #17728

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Handle ECS-compatible deprecation logs emitted by ES 8.0.0+ #17728

merged 4 commits into from
Apr 17, 2020

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 15, 2020 •
edited by zube bot
Loading

What does this PR do?

With elastic/elasticsearch#47105 merged, starting with 8.0.0, Elasticsearch will emit ECS-compatible deprecation (and other types of) logs. This PR enhances the elasticsearch/deprecation fileset's ingestion pipeline to handle this new deprecation log format, while also remaining backwards-compatible with the previous (7.x) deprecation log format.

Why is it important?

So the Filebeat elasticsearch/deprecation fileset can handle current as well as upcoming Elasticsearch deprecation log formats.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@ycombinator ycombinator marked this pull request as draft April 15, 2020 13:58
@ycombinator ycombinator mentioned this pull request Apr 15, 2020
Closed
3 tasks
@ycombinator ycombinator added the in progress Pull request is currently in progress. label Apr 15, 2020
@ycombinator ycombinator requested a review from leehinman April 16, 2020 15:10
@ycombinator ycombinator marked this pull request as ready for review April 16, 2020 15:10
@ycombinator ycombinator added [zube]: In Review needs_backport PR is waiting to be backported to other branches. Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 v8.0.0 and removed in progress Pull request is currently in progress. labels Apr 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@ycombinator ycombinator force-pushed the fb-es-deprecation-800-ecs branch from e991c03 to 3c37cb1 Compare April 16, 2020 15:11
leehinman
leehinman approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator ycombinator force-pushed the fb-es-deprecation-800-ecs branch from 3c37cb1 to 2a58251 Compare April 16, 2020 22:06
@ycombinator
Copy link
Contributor Author

Travis CI is green and Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit dfd1c37 into elastic:master Apr 17, 2020
@ycombinator ycombinator deleted the fb-es-deprecation-800-ecs branch April 17, 2020 11:18
@ycombinator ycombinator mentioned this pull request Apr 17, 2020
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Apr 17, 2020
ycombinator added a commit that referenced this pull request Apr 25, 2020
@ycombinator
[7.x] Handle ECS-compatible deprecation logs emitted by ES 8.0.0+ (#1…
5a91033 
…7728) (#17788)

* Handle ECS-compatible deprecation logs emitted by ES 8.0.0+ (#17728)

* Adding sample logs

* Handle ECS-compatible deprecation logs emitted by ES 8.0.0+

* Adding CHANGELOG entry

* Fixing CHANGELOG after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @elasticmachine @leehinman @andresrc