[7.x] Adding unit tests for publisher output (#17460) #17625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
[zube]: In Review
backport
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
Team:Services
kaiyan-sheng
approved these changes
Apr 13, 2020
ycombinator
force-pushed
the
backport/7.x/pr-17460
branch
from
52dda1d to
676c5d7
Compare
* Adding unit tests for publisher output * Adding another unit test (TODO) * Adding unit test for closing worker midway * Reorganizing imports * Output PRNG seed + provide flag to specify seed * Cancel batch with netClient if it is closed * Use waitUntil loop instead of hard sleep * Making mockClient threadsafe * Removing goroutine from happy path unit test * Using testing/quick * Increase batch sizes in tests * Adding sleep to ensure some batches are still at time of close * Experiment witht with slihigher sleep time * Moving sleep to publish time * Increase publish latency * Increasing publish latency again * Removing publishLatency * Fix timeout to large value * Make first client block after publishing X events * Actually block publishing * Reduce number of batches to prevent running out of memory * Bumping up # of batches * Bumping up # of batches again * Try different strategy - publish 80% of events * Cranking up sleep time in publish blocking * Only publish first 20% of events * Make sure to return batch for retrying * Adding debugging statements to see what's happening in Travis * More robust to race conditions * Restricting quick iterations to 50 to see if that helps in Travis * Put entire loop into goroutine * Renaming tests * Emulate blocking + mockable publish behavior * Removing retry and return * Clarify intent with comment * Setting # of quick iterations to 25
ycombinator
force-pushed
the
backport/7.x/pr-17460
branch
from
676c5d7 to
430c358
Compare
|
CI test failures are unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: