Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Fix s3 dashboard to use aws.s3.bucket.name field name #17542

Merged
merged 3 commits into from
Apr 7, 2020
Merged

[Metricbeat] Fix s3 dashboard to use aws.s3.bucket.name field name #17542

merged 3 commits into from
Apr 7, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 6, 2020 •
edited
Loading

This is a PR to fix a bug in aws s3 overview dashboard introduced by #13581

Instead of "terms_field": "aws.s3_daily_storage.bucket.name" and "terms_field": "aws.s3_request.bucket.name", it should use the new field name aws.s3.bucket.name.

@kaiyan-sheng kaiyan-sheng self-assigned this Apr 6, 2020
@kaiyan-sheng kaiyan-sheng added bug needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Apr 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

blakerouse
blakerouse approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kaiyan-sheng kaiyan-sheng merged commit 4d906ec into elastic:master Apr 7, 2020
@kaiyan-sheng kaiyan-sheng deleted the fix_s3_dashboard branch April 7, 2020 02:08
@kaiyan-sheng kaiyan-sheng mentioned this pull request Apr 7, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 7, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Apr 7, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request Apr 7, 2020
@kaiyan-sheng
Cherry-pick #17542 to 7.7: [Metricbeat] Fix s3 dashboard to use aws.s…
99a9986 
…3.bucket.name field name (#17557)

* [Metricbeat] Fix s3 dashboard to use aws.s3.bucket.name field name (#17542)

* Fix s3 dashboard to use aws.s3.bucket.name field name

* add changelog

(cherry picked from commit 4d906ec)

* update changelog
kaiyan-sheng added a commit that referenced this pull request Apr 7, 2020
@kaiyan-sheng
Cherry-pick #17542 to 7.x: [Metricbeat] Fix s3 dashboard to use aws.s…
2aab349 
…3.bucket.name field name (#17556)

* [Metricbeat] Fix s3 dashboard to use aws.s3.bucket.name field name (#17542)

* Fix s3 dashboard to use aws.s3.bucket.name field name

* add changelog

(cherry picked from commit 4d906ec)

* update changelog
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng
Cherry-pick elastic#17542 to 7.7: [Metricbeat] Fix s3 dashboard to us…
528b2d7 
…e aws.s3.bucket.name field name (elastic#17557)

* [Metricbeat] Fix s3 dashboard to use aws.s3.bucket.name field name (elastic#17542)

* Fix s3 dashboard to use aws.s3.bucket.name field name

* add changelog

(cherry picked from commit eec0c9c)

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
bug review Team:Platforms Label for the Integrations - Platforms team v7.7.0 v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @blakerouse @andresrc