Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Unix stream socket input source #17492

Merged
merged 17 commits into from
Apr 21, 2020
Merged

[Filebeat] Unix stream socket input source #17492

merged 17 commits into from
Apr 21, 2020

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Apr 3, 2020 •
edited by zube bot
Loading

What does this PR do?

This adds Unix stream socket support as an input source.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@andrewstucki andrewstucki changed the title [WIP][Filebeat] Unix stream socket input source [Filebeat] Unix stream socket input source Apr 4, 2020
andrewkroh
andrewkroh reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a few minor comments.

filebeat/input/unix/input.go Outdated Show resolved Hide resolved
filebeat/input/unix/input.go Outdated Show resolved Hide resolved
filebeat/inputsource/common/handler.go Outdated Show resolved Hide resolved
filebeat/inputsource/common/listener.go Outdated Show resolved Hide resolved
filebeat/inputsource/unix/config.go Outdated Show resolved Hide resolved
@andrewstucki
Copy link
Contributor Author

Looks like the test failure is unrelated:

12:09:35  [error] 0.17% test_registrar.Test.test_clean_removed: 0.2795s

andrewkroh
andrewkroh approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewstucki andrewstucki merged commit 3b99438 into elastic:master Apr 21, 2020
@andrewstucki andrewstucki deleted the unix-sockets branch April 21, 2020 01:28
@andrewstucki andrewstucki mentioned this pull request Apr 21, 2020
Merged
6 tasks
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Apr 21, 2020
[Filebeat] Unix stream socket input source (elastic#17492)
5710540 
* initial common refactor

* Fix up unix and add license info

* Fix inputs

* Clean up handlers

* Update changelog and docs

* Fix added input

* Fix tests

* Add unix socket system tests

* add systems tests for syslog unix input

* pep autoformat

* Disable unix tests for Windows since Python 3.8 doesn't support AF_UNIX

* pep autoformat

* Address feedback

* fix test

(cherry picked from commit 3b99438)
andrewstucki pushed a commit that referenced this pull request Apr 21, 2020
Cherry-pick #17492 to 7.x: [Filebeat] Unix stream socket input source (…
a1da232 
…#17851)

* [Filebeat] Unix stream socket input source (#17492)

* initial common refactor

* Fix up unix and add license info

* Fix inputs

* Clean up handlers

* Update changelog and docs

* Fix added input

* Fix tests

* Add unix socket system tests

* add systems tests for syslog unix input

* pep autoformat

* Disable unix tests for Windows since Python 3.8 doesn't support AF_UNIX

* pep autoformat

* Address feedback

* fix test

(cherry picked from commit 3b99438)

* Fix changelog
@andrewkroh
Copy link
Member

@andrewstucki Can you please follow-up on this PR with three things:

  • add documentation for the input (you added docs to syslog but not for the unix input type)
  • add beta labels to the new docs ([]beta)
  • add a cfgwarn.Beta(...) to the code to log a beta warning to the user

This was referenced Apr 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@adriansr adriansr Awaiting requested review from adriansr

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat review v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filebeat Enhancement: Support reading from UNIX stream sockets
3 participants
@andrewstucki @elasticmachine @andrewkroh