Postpone selection of the logger output #17448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
bug
libbeat
v7.7.0
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
andrewkroh
approved these changes
Apr 2, 2020
This was referenced Apr 2, 2020
urso
pushed a commit
that referenced
this pull request
Apr 3, 2020
(cherry picked from commit d6c2aac)
urso
pushed a commit
that referenced
this pull request
Apr 3, 2020
(cherry picked from commit d6c2aac)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#17455) (cherry picked from commit e5515be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Postpone the selection of the log output after configuration file has been read and CLI flags have been assigned.
Why is it important?
Fix regression found during 7.7.0 testing. The configured log output is not respected and can not be overwritten. This change ensures that CLI flags and configuration files are always respected.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs