Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17147 to 7.x: Add support for MODULE in mage goIntegTest for metricbeat #17409

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 1, 2020

Cherry-pick of PR #17147 to 7.x branch. Original message:

What does this PR do?

Add support for MODULE environment variable in mage goIntegTest for Metricbeat to run integration tests for an specific module. For example, to run integration tests for sql module only:

MODULE=sql mage goIntegTest

Why is it important?

Metricbeat integration tests are slow, running them as they are run in CI requires to run all tests, but when running them locally you are usually interested in running a single module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Use MODULE environment variable to run integration tests of a single module, for example:

MODULE=sql mage goIntegTest

)

Add support for `MODULE` environment variable in `mage goIntegTest`
for Metricbeat to run integration tests for an specific module. For example,
to run integration tests for sql module only:

  MODULE=sql mage goIntegTest

(cherry picked from commit 13592b0)
@jsoriano jsoriano force-pushed the backport_17147_7.x branch from 3b99323 to ad2e419 Compare April 1, 2020 17:17
@jsoriano jsoriano merged commit ddcc60c into elastic:7.x Apr 6, 2020
@jsoriano jsoriano deleted the backport_17147_7.x branch April 6, 2020 14:34
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants