Add dashboards for Google Cloud Audit and AWS CloudTrail #17379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
enhancement
review
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
kaiyan-sheng
reviewed
Apr 1, 2020
There was a problem hiding this comment.
LGTM! Could you also add the screenshots into https://github.com/elastic/beats/tree/master/filebeat/docs/images please? Some mage commands will probably be needed after that to update the docs.
andrewkroh
force-pushed
the
feature/fb/aws-gcp-dashboards
branch
from
9dfce20
to
aa8366d
Compare
Add dashboards for Google Cloud Audit and AWS Cloud Trail.
googlecloud/audit was missing docs so I added them.
andrewkroh
force-pushed
the
feature/fb/aws-gcp-dashboards
branch
from
aa8366d
to
3864e44
Compare
|
@kaiyan-sheng Good idea. Those screen shots are now added to the documentation for the respective modules. |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
May 6, 2020
Add dashboards for Google Cloud Audit and AWS Cloud Trail. Add images to docs googlecloud/audit was missing docs so I added them. (cherry picked from commit a7ada06)
andrewkroh
added
v7.8.0
and removed
needs_backport
andrewkroh
added a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add dashboards for Google Cloud Audit and AWS Cloud Trail.
Screenshots
AWS CloudTrail
Google Cloud Audit
