-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metricbeat mysql: Add config.epr.yml #17323
Conversation
If this file is required and cannot be change, WDYT about an additional one |
metricbeat/metricbeat.reference.yml
Outdated
# - "galera_status" | ||
- "galera_status" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this normally means that the metricset is disabled by default, do we really need to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this way (enabling metricset) to ensure that the configuration option is used with the metricset.
In this case, if I enable "galera_status", the script will include all configuration options related to it.
About reference config: it's only use is compiling the metricbeat.reference.yml, which holds a reference file of all default config values for the user. There is nothing really interacting with it. I'm +1 on a |
This will work for me too. I can adjust the PR. |
I like the idea of having some assets in Beats that will simplify the migration. But the part I wonder is if this case we should perhaps directly jump to the end format, meaning having the manifest file instead with parts of the info? |
@ruflin Having an entire |
@mtojek Agree, and that manual work should probably directly happening when we review the packages. Just having a specific epr config file sounds also like a lot of additional work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in for the shake of moving MySQL integration forward. If we finally go for this approach we will need to document it after the first batch of integrations are in
Hmm, content of the |
This PR adds the
config.epr.yml
file to the Metricbeatmysql
module.I plan to use this file as source of configuration option for the
import-beats
script in https://github.com/elastic/package-registry project.