Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17015 to 7.x: Use max in k8s overview dashboard aggregations #17052

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Mar 17, 2020

Cherry-pick of PR #17015 to 7.x branch. Original message:

What does this PR do?

Changes types of aggregations from sum to max on the following visualisations of Kubernetes Overview:

  • Network in by node [Metricbeat Kubernetes] ECS
  • Network out by node [Metricbeat Kubernetes] ECS
  • Top CPU intensive pods [Metricbeat Kubernetes] ECS

Why is it important?

We should not be using a sum on kubernetes.pod.network.rx.bytes,
kubernetes.pod.network.tx.bytes, and kubernetes.container.cpu.usage.core.ns;
these fields are counters.
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/stats/v1alpha1/types.go#L165
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/stats/v1alpha1/types.go#L198
We should use max instead.

Related issues

Screenshots

Screenshot 2020-03-16 at 11 40 00
Screenshot 2020-03-16 at 11 39 39

We should not be using a sum on kubernetes.pod.network.rx.bytes,
kubernetes.pod.network.tx.bytes, and kubernetes.container.cpu.usage.core.ns;
these fields are counters.


(cherry picked from commit 0a2b3f4)
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ChrsMark ChrsMark merged commit 652426c into elastic:7.x Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants