Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16971 to 7.x: Make use of prometheus filter settings on IBM-MQ Metricbeat module #17048

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Mar 17, 2020

Cherry-pick of PR #16971 to 7.x branch. Original message:

What does this PR do?

Refactoring the manifest file of the qmgr metricset. Previously a processor was used to filter out non ibmmq metrics. This commit replaces the processor with the more elegant metrics_filter that was introduced recently.

Why is it important?

Using the metrics_filter is cleaner and easier to read.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

  • Run the IBM MQ container ("docker-compose up" in x-pack/metricbeat/module/ibmmq) locally.
  • Run metricbeats with the ibmmq module enabled.
  • In Kibana look at the imported metric data -> For metricset qmgr, you should see only metrics beginning with "prometheus.metrics.ibmmq_qmgr"
  • Remove the metrics_filter from the manifest file and restart metricbeats
  • In Kibana look at the imported metric data -> For metricset qmgr, you should see a number of metrics not beginning with "prometheus.metrics.ibmmq_qmgr" besides metrics beginning with that prefix.

@ChrsMark ChrsMark requested a review from mtojek March 17, 2020 08:30
@ChrsMark ChrsMark self-assigned this Mar 17, 2020
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ChrsMark ChrsMark merged commit 1e5ae90 into elastic:7.x Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants