-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark API response parsing code #17046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
the
Team:Services
(Deprecated) Label for the former Integrations-Services team
label
Mar 17, 2020
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
added
needs_backport
PR is waiting to be backported to other branches.
v7.7.0
v8.0.0
Metricbeat
Metricbeat
module
Feature:Stack Monitoring
labels
Mar 17, 2020
Pinging @elastic/stack-monitoring (Stack monitoring) |
2 tasks
jsoriano
approved these changes
Mar 17, 2020
Travis CI is green and Jenkins CI failures are unrelated. Merging. |
ycombinator
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Mar 17, 2020
ycombinator
added a commit
that referenced
this pull request
Mar 18, 2020
ycombinator
added a commit
that referenced
this pull request
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Stack Monitoring
Metricbeat
Metricbeat
module
Team:Services
(Deprecated) Label for the former Integrations-Services team
v7.7.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the API response parsing code in the
elasticsearch/index
metricset benchmark-able, and adds a benchmark test for it. It is in preparation for #16538.Why is it important?
To prove that the changes in #16538 will have a significant impact on memory usage while parsing the API response from Elasticsearch.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesHow to test this PR locally
Sample benchmark results
In terms of memory, the current API response parsing implementation consumed 13.46 MB.
Related issues
elasticsearch.index
metricset #16538