Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16900 to 7.x: Update fields.ecs.yml to ECS v1.5.0 #17044

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 16, 2020

Cherry-pick of PR #16900 to 7.x branch. Original message:

What does this PR do?

Updates the fields.yml and generated Go code to ECS v1.5.0.

Why is it important?

So we can update Beats to ship data using 1.5 fields.

Why no changelog entry?

Because this update doesn't impact the user until we start adding/updating data sources that populate those fields.

* Update vendored elastic/ecs to v1.5.0

* Update fields.ecs.yml to v1.5.0

* Fix encoding issue in fields' docs

Fields' docs generation is failing in some systems when non-ascii
characters appear in the fields descriptions and/or examples.

* Patch fields.ecs.yml to avoid parser trouble

The fields docs generator was having trouble representing an example as
an object in a way that was consistent across different python3 versions
due to keys in a dict being serialised to string with different
orderings. This caused checks to fail.

(cherry picked from commit 76dcd34)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit d384371 into elastic:7.x Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants