Fix flaky test test_stats #17034
Merged
Fix flaky test test_stats #17034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests on stats API can finish even before the mocked beat has completed its initialization, so it can receive the signal to stop before it can handle signals, terminating with an status code -15 (killed by SIGTERM), instead of the expected status code 0. Check that the beat has been completely started before trying to kill it, and move common code to setUp/tearDown. Fix also an incorrect error message.
jsoriano
added
review
flaky-test
|
Pinging @elastic/integrations (Team:Integrations) |
ycombinator
reviewed
Mar 16, 2020
ycombinator
approved these changes
Mar 16, 2020
jsoriano
added
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 16, 2020
Tests on stats API can finish even before the mocked beat has completed its initialization, so it can receive the signal to stop before it can handle signals, terminating with an status code -15 (killed by SIGTERM), instead of the expected status code 0. Check that the beat has been completely started before trying to kill it, and move common code to setUp/tearDown. Fix also an incorrect error message. (cherry picked from commit 825cf05)
jsoriano
removed
the
needs_backport
jsoriano
added a commit
that referenced
this pull request
Mar 17, 2020
Tests on stats API can finish even before the mocked beat has completed its initialization, so it can receive the signal to stop before it can handle signals, terminating with an status code -15 (killed by SIGTERM), instead of the expected status code 0. Check that the beat has been completely started before trying to kill it, and move common code to setUp/tearDown. Fix also an incorrect error message. (cherry picked from commit 825cf05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on stats API can finish even before the mocked beat has completed
its initialization, so it can receive the signal to stop before it can
handle signals, terminating with an status code -15 (killed by SIGTERM),
instead of the expected status code 0.
Check that the beat has been completely started before trying to kill
it, and move common code to setUp/tearDown.
Fix also an incorrect error message.