Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New input for Crowdstrike Falcon events #16988
New input for Crowdstrike Falcon events #16988
Changes from 23 commits
c07195a
9b7877e
8f1e14c
fb9990d
a6d2c11
3c6eeaf
a1795e9
2b5c4df
b5ba30e
e52175d
d648645
124f087
c70dc4b
55388b7
d3de4d6
8716db4
e62a3da
585694f
3c3ffb2
31a02e5
20d0584
1a133be
3494c3b
bae9eec
4df6b91
5a1a67b
0d7c9e7
dbd68ac
cefc7f8
e3a8d83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to keep this since we're still doing this (two datasets), just from the same fileset. That okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's interesting. I didn't notice that the module was setting the
event.dataset
values. We've never had a case AFAIK where a fileset produced anevent.dataset
value other than the default of{module}.{fileset}
. I don't think this will cause any issues. I think it would be good to callout the event.dataset values that it produces in this paragraph.