Trigger travis builds on more cases #16985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger travis builds also for x-pack beats. Also trigger all builds if dev-tools or .travis.yml file change. Changes there can also affect all Travis builds.
|
Pinging @elastic/integrations (Team:Integrations) |
jsoriano
changed the title
andrewkroh
approved these changes
Mar 16, 2020
urso
reviewed
Mar 23, 2020
| @@ -1,11 +1,14 @@ | |||
| #!/usr/bin/env bash | |||
| set -exuo pipefail | |||
|
|
|||
| # commit range to check for. For example master...<PR branch> | |||
| # Changes on these files will trigger all builds. | |||
| COMMON_DIRLIST="vendor dev-tools .travis.yml" | |||
There was a problem hiding this comment.
Yeah, it would make sense, opened PR for that #17387, thanks!
This was referenced Apr 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Trigger travis builds also for x-pack beats.
Also trigger all builds if dev-tools or .travis.yml file change. Changes
there can also affect all Travis builds.
Why is it important?
Changes in x-pack beats are not triggering builds, see #16971 for example.
Add a common place to add files that can affect all builds.