Cherry-pick #16048 to 7.x: Add metadata to Windows exe files #16944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
backport_16048_7.x
branch
from
3e8c6fd to
49943b5
Compare
andresrc
added
[zube]: Inbox
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
kvch
approved these changes
Mar 13, 2020
|
The PR has to be rebased. |
andrewkroh
force-pushed
the
backport_16048_7.x
branch
from
49943b5 to
1ffbbd6
Compare
This adds metadata to the Windows .exe files that the build produces. This makes our binaries a little more friendly to automation on Windows because you can check the version programmatically with ease. It also makes is easy for end user to inspect some details about the file from the file properties dialog in Windows. Closes elastic#15232 For example: ``` PS C:\vagrant\winlogbeat > (Get-Info .\winlogbeat.exe).VersionInfo | Format-List OriginalFilename : winlogbeat.exe FileDescription : Winlogbeat ships Windows event logs to Elasticsearch or Logstash. ProductName : Winlogbeat Comments : commit=8d6cf58f347579188d707421da6b70b2f66701ea CompanyName : Elastic FileName : C:\vagrant\winlogbeat\winlogbeat.exe FileVersion : 8.0.0 ProductVersion : 8.0.0 IsDebug : False IsPatched : False IsPreRelease : False IsPrivateBuild : False IsSpecialBuild : False Language : Language Neutral LegalCopyright : Copyright Elastic, License ASL 2.0 LegalTrademarks : PrivateBuild : SpecialBuild : FileVersionRaw : 8.0.0.0 ProductVersionRaw : 8.0.0.0 ``` (cherry picked from commit 695b167)
andrewkroh
force-pushed
the
backport_16048_7.x
branch
from
1ffbbd6 to
3e3be59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16048 to 7.x branch. Original message:
This adds metadata to the Windows .exe files that the build produces. This makes our binaries a little more friendly to automation on Windows because you can check the version programmatically with ease. It also makes is easy for end user to inspect some details about the file from the file properties dialog in Windows.
Closes #15232
For example: