Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Libbeat] Remove global logger from libbeat publisher and reader" #16914

Closed
wants to merge 1 commit into from
Closed

Revert "[Libbeat] Remove global logger from libbeat publisher and reader" #16914

wants to merge 1 commit into from

Conversation

kaiyan-sheng
Copy link
Contributor

Reverts #16886

ycombinator
ycombinator approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry you had to revert #16886 😞

@kaiyan-sheng
Copy link
Contributor Author

Instead of reverting the PR, #16915 will fix the problem.

@kaiyan-sheng kaiyan-sheng deleted the revert-16886-logging_refactor branch March 10, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiyan-sheng @ycombinator