Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update add_kubernetes_metadata processor to use *logp.Logger #16913

Merged
merged 2 commits into from
Mar 10, 2020
Merged

update add_kubernetes_metadata processor to use *logp.Logger #16913

merged 2 commits into from
Mar 10, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This is a follow-up PR for #16866 to replace logging in add_kubernetes_metadata processor to use *logp.Logger.

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 9, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Mar 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kaiyan-sheng kaiyan-sheng merged commit 1516064 into elastic:master Mar 10, 2020
@kaiyan-sheng kaiyan-sheng deleted the k8s_logging branch March 10, 2020 18:24
@kaiyan-sheng kaiyan-sheng added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 17, 2020
kaiyan-sheng added a commit that referenced this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants