Cherry-pick #14706 to 7.x: Fix and extend logging of light modules load errors #16775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
backport_14706_7.x
branch
from
eba382d to
334936c
Compare
Two things are solved here: * Errors were being logged with logp.Error that doesn't actually log anything, use a local logger and its Errorf method instead. * Log errors also when listing modules for string representation. This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors are logged if permissions are not correct. Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors. (cherry picked from commit 10da237)
jsoriano
force-pushed
the
backport_14706_7.x
branch
from
334936c to
ceaa3ef
Compare
kaiyan-sheng
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #14706 to 7.x branch. Original message:
Two things are solved here:
logp.Errorthat doesn't actually log anything, use a local logger and itsErrorfmethod instead.This was hiding errors, what was specially confusing when permissions are not correct during development and testing, now errors like this one are logged if permissions are not correct:
Some errors have been rephrased so logged errors start with uppercase, and "failed to" is not logged in all nested errors.