Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Add documentation for tags_filter and tags #16731

Merged
merged 1 commit into from
Mar 3, 2020
Merged

[Metricbeat] Add documentation for tags_filter and tags #16731

merged 1 commit into from
Mar 3, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to add tags_filter in ec2 metricset documentation and tags into cloudwatch metricset documentation. The difference in naming here needs to be changed. I'd like to change tags in cloudwatch metricset to be tags_filter to match ec2 in the future in a separate PR.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner March 2, 2020 18:12
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 2, 2020
@kaiyan-sheng kaiyan-sheng added docs Metricbeat Metricbeat review Team:Platforms Label for the Integrations - Platforms team needs_backport PR is waiting to be backported to other branches. labels Mar 2, 2020
@kaiyan-sheng kaiyan-sheng merged commit 10ed037 into elastic:master Mar 3, 2020
@kaiyan-sheng kaiyan-sheng deleted the tags_filter_doc branch March 3, 2020 14:09
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Mar 3, 2020
@kaiyan-sheng kaiyan-sheng added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 3, 2020
kaiyan-sheng added a commit that referenced this pull request Mar 3, 2020
@dedemorton dedemorton added the needs_edit Indicates that the doc changes need an edit after merging. label Mar 4, 2020
@dedemorton
Copy link
Contributor

dedemorton commented Mar 20, 2020

I've created a meta issue to track the content that requires an edit, so I'm removing the needs_edit
label.

@dedemorton dedemorton removed the needs_edit Indicates that the doc changes need an edit after merging. label Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Metricbeat Metricbeat review Team:Platforms Label for the Integrations - Platforms team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants