Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redis Enterprise] Fix flaky: wait for metrics to be emitted #16721

Merged
merged 1 commit into from
Mar 3, 2020
Merged

[Redis Enterprise] Fix flaky: wait for metrics to be emitted #16721

merged 1 commit into from
Mar 3, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Mar 2, 2020 •
edited
Loading

This PR adjusts Dockerfile of redisentrprise to wait with announcing "healthy" status until relevant metrics are emitted.

Tests have been failiing because all fetched metrics were filtered (exclude_metrics).

Issue: #16718

@mtojek mtojek added the Metricbeat Metricbeat label Mar 2, 2020
@mtojek mtojek requested a review from a team March 2, 2020 08:07
@mtojek mtojek self-assigned this Mar 2, 2020
kaiyan-sheng
kaiyan-sheng approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like travis is happy now with this change. Thanks!

@mtojek mtojek merged commit cdadced into elastic:master Mar 3, 2020
mtojek added a commit to mtojek/beats that referenced this pull request Mar 3, 2020
@mtojek
Wait for emitted metrics (elastic#16721)
9b380d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@mtojek mtojek

Labels
Metricbeat Metricbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @kaiyan-sheng