-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] add collecting tags for rds metricset #16605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
enhancement
needs_backport
PR is waiting to be backported to other branches.
review
Team:Platforms
Label for the Integrations - Platforms team
labels
Feb 26, 2020
ChrsMark
reviewed
Feb 28, 2020
ChrsMark
reviewed
Feb 28, 2020
ChrsMark
reviewed
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. I left just one small comment :)
…nd DBInstanceStatus
ChrsMark
approved these changes
Mar 9, 2020
5 tasks
kaiyan-sheng
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Mar 10, 2020
kaiyan-sheng
added a commit
that referenced
this pull request
Mar 11, 2020
andresrc
added
test-plan-added
This PR has been added to the test plan
and removed
[zube]: Done
labels
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
review
Team:Platforms
Label for the Integrations - Platforms team
test-plan
Add this PR to be manual test plan
test-plan-added
This PR has been added to the test plan
v7.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds tag collection in rds metricset by default.
Why is it important?
Tags are important part of metadata for RDS instances. With this PR, users can collect metrics from RDS and use tags for filtering.
Checklist
How to test this PR locally
Create RDS with tags first, then use config below to start aws module:
You should see tags collected in events, for example:
Also test with
tags_filter
:Related issues