Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudfoundry input for filebeat #16586

Merged
merged 3 commits into from
Feb 26, 2020
Merged

Add cloudfoundry input for filebeat #16586

merged 3 commits into from
Feb 26, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Feb 26, 2020 •
edited by andresrc
Loading

What does this PR do?

Add cloudfoundry input to x-pack filebeat.

Why is it important?

To support Cloud Foundry.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Sends http access, log messages, and error logs to elasticsearch.

How to test this PR locally

Run x-pack build of filebeat with the following configuration, with a deploy cloudfoundry. Substitute the configuration variables based on the cloudfoundry deployment and authentication.

filebeat.inputs:
  - type: cloudfoundry
    api_address: https://api.dev.cfdev.sh
    client_id: firehose-to-filebeat
    client_secret: verysecret
    ssl:
      verification_mode: none

output.console:
  pretty: true

Related issues

Use cases

Screenshots

Logs

@blakerouse blakerouse added enhancement Team:Platforms Label for the Integrations - Platforms team Filebeat Filebeat labels Feb 26, 2020
@exekias exekias requested a review from a team February 26, 2020 15:43
exekias
exekias reviewed Feb 26, 2020
View reviewed changes
x-pack/filebeat/docs/inputs/input-cloudfoundry.asciidoc
[float]
==== `api_address`

The URL of the Cloud Foundry API. Optional. Default: "http://api.bosh-lite.com".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are these defaults defined, is that the library default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it comes from the library.

exekias
exekias reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the defaults questions

@blakerouse blakerouse merged commit ed693e9 into elastic:master Feb 26, 2020
@blakerouse blakerouse deleted the filebeat-cf-input branch February 26, 2020 15:55
blakerouse added a commit to blakerouse/beats that referenced this pull request Feb 26, 2020
@blakerouse
Add cloudfoundry input for filebeat (elastic#16586)
aaf0024 
* Add cloudfoundry input.

* Fix issue with http transport.

* Add input documentation.

(cherry picked from commit ed693e9)
@blakerouse blakerouse mentioned this pull request Feb 26, 2020
Merged
4 tasks
blakerouse added a commit that referenced this pull request Feb 27, 2020
@blakerouse
Add cloudfoundry input for filebeat (#16586) (#16614)
b18b864 
* Add cloudfoundry input.

* Fix issue with http transport.

* Add input documentation.

(cherry picked from commit ed693e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat Team:Platforms Label for the Integrations - Platforms team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakerouse @exekias @andresrc