Remove experimental flag from append_fields #16576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simitt, Does this PR close elastic/apm-server#1371 as well? Or do you envision additional changes to the documentation before that issue is closed? |
urso
approved these changes
Feb 25, 2020
|
Can you please add a changelog entry? |
|
Thanks for the review, pushed the changelog now. Failing tests were unrelated. @bmorelli25 the docs already mention everything important related to this config option (overwriting templates, when they are applied etc). In my opinion no changes needed for the docs. |
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 26, 2020
simitt
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the
experimentalflag from theappend_fieldsconfiguration for beats.Why is it important?
The config option has been added some time ago and became a common way of adding fields to index templates for beats/APM Server. There are no breaking changes expected, so the feature can be considered GA.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
This is a configuration documentation change.
Related issues
Closes #15605