Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k8s pod annotations tier in metadata #16554

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

ChrsMark
Copy link
Member

Follow-up of #16480 PR.

It was found also that kubernetes.annotations.* do not follow the schema defined at

any more.

This PR aims to fix it.

Not sure if we should fix it in general for all resources at

safemapstr.Put(meta, strings.ToLower(kind)+".annotations", annotationsMap)
and not only for pods. I think we should do it sooner or later when we define a general strategy about this schema as mentioned #16480 (comment).

@ChrsMark ChrsMark added bug needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team autodiscovery v7.7.0 v7.6.1 Team:Platforms Label for the Integrations - Platforms team labels Feb 25, 2020
@ChrsMark ChrsMark requested review from exekias and a team February 25, 2020 12:48
@ChrsMark ChrsMark self-assigned this Feb 25, 2020
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Copy link
Member Author

Jenkins build was successful for linux, merging this one.

1 similar comment
@ChrsMark
Copy link
Member Author

Jenkins build was successful for linux, merging this one.

@ChrsMark ChrsMark merged commit 1ba7b36 into elastic:master Feb 25, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Feb 25, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Feb 25, 2020
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Feb 25, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Feb 25, 2020
ChrsMark added a commit that referenced this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery bug Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team v7.6.1 v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants