Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Enhancement - Pattern for Cisco Message 734001. #16543

Closed
wants to merge 1 commit into from
Closed

[Filebeat] Enhancement - Pattern for Cisco Message 734001. #16543

wants to merge 1 commit into from

Conversation

MarcusCaepio
Copy link
Contributor

What does this PR do?

Adds a new pipeline pattern for the cisci asa/ftd log messages with the event id 734001.
The split part is needed, because one has to be able to search for an
explicit dap_record. As the records order and number can vary a lot,
just saving the whole string makes no sense. I choosed "user.email", "source.ip" based on the ECS and "cisco.connection_type", "cisco.dap_records" as looking to the syslog messages docs,
they also call it like that.

Why is it important?

We need this filter for troubleshooting VPN Connections

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Test Logfile is added

Related issues

Closes #16212.

@MarcusCaepio MarcusCaepio requested a review from a team as a code owner February 25, 2020 09:05
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just a minor comment on fields.yml.

Can you please add an entry to the CHANGELOG.next.asciidoc file under the Added/Filebeat section.

From checking the Travis CI output, it looks like you need to run make update from the filebeat and/or x-pack/filebeat directories to re-generate some files.


- name: dap_records
type: keyword
description: ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: ->
description: >

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad

This looks good to me. Just a minor comment on fields.yml.

Can you please add an entry to the CHANGELOG.next.asciidoc file under the Added/Filebeat section.

From checking the Travis CI output, it looks like you need to run make update from the filebeat and/or x-pack/filebeat directories to re-generate some files.

My bad with the wrong "-", I changed them and made a "make update" in the /beats/filebeat/xpack and /beats/filebeat folder


- name: dap_records
type: keyword
description: ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: ->
description: >

@MarcusCaepio
Copy link
Contributor Author

This looks good to me. Just a minor comment on fields.yml.

From checking the Travis CI output, it looks like you need to run make update from the filebeat and/or x-pack/filebeat directories to re-generate some files.

I did a "make update" both in beats/x-pack/filebeat/ and /beats/filebeat. Pipeline still failing.

Can you please add an entry to the CHANGELOG.next.asciidoc file under the Added/Filebeat section.

Where can I find it?

    Maybe fixes #16212
    The split part is needed, because one has to be able to search for an
    explicit dap_record. As the records order and number can vary a lot,
    just saving the whole string makes no sense. I choosed "cisco.user" and
    "cisco.connection_type", as looking to the syslog messages docs,
    they also call it like that.
@MarcusCaepio
Copy link
Contributor Author

MarcusCaepio commented Feb 26, 2020

I will retry it again merging the current state, as the pipeline fails @andrewkroh @ChrsMark can you please (please) delete this PR as in the commit ammend is a wrong author? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat - Module Cisco-ASA] Parsing of Cisco Event Message 734001
4 participants