-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Update fileset input merging to replaces paths and append processors. #16450
Merged
blakerouse
merged 3 commits into
elastic:master
from
blakerouse:fix-fileset-input-merging
Feb 24, 2020
Merged
[Filebeat] Update fileset input merging to replaces paths and append processors. #16450
blakerouse
merged 3 commits into
elastic:master
from
blakerouse:fix-fileset-input-merging
Feb 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate fileset input merging to replaces paths and append procesors.
exekias
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!
Can you add a CHANGELOG entry?
@exekias Added |
blakerouse
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Feb 24, 2020
2 tasks
blakerouse
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Feb 24, 2020
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Feb 24, 2020
…processors. (elastic#16450) * Update go-ucfg to 0.8.3 to use the new field merging adjustments. Update fileset input merging to replaces paths and append procesors. * Add changelog entry. (cherry picked from commit 9695092)
@blakerouse and @exekias Will that fix my issue? #16464 (comment) ? |
@nerddelphi yes it will fix the issue that you described in your last comment for the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates vendored package of go-ucfg to 0.8.3, needed to use the new field merging adjustments. Updates fileset input merging to replaces paths and append processors when merging configurations.
Why is it important?
Allows a container to define modules that contain processors at the same time as adding extra processors during autodiscovery.
docker run -l 'co.elastic.logs/processors.add_fields={"fields":{"foo":"bar"}}' -l co.elastic.logs/module=elasticsearch busybox echo hello
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Run filebeat with configuration:
Start container:
docker run -l 'co.elastic.logs/processors.add_fields={"fields":{"foo":"bar"}}' -l co.elastic.logs/module=elasticsearch busybox echo hello
Related issues
Use cases
Screenshots
Logs