Add container azure metricset #16421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narph
added
Team:Platforms
exekias
approved these changes
Mar 3, 2020
| # client_secret: '${AZURE_CLIENT_SECRET:""}' | ||
| # tenant_id: '${AZURE_TENANT_ID:""}' | ||
| # subscription_id: '${AZURE_SUBSCRIPTION_ID:""}' | ||
| # refresh_list_interval: 600s |
There was a problem hiding this comment.
This file is starting to grow a lot. Would it make sense to group all metricsets that share the same params? This can happen on a different PR
There was a problem hiding this comment.
could do, will add this to the new PR
Comment on lines
+26
to
+50
| clientId, ok := os.LookupEnv("AZURE_CLIENT_ID") | ||
| if !ok { | ||
| return nil, errors.New("missing AZURE_CLIENT_ID key") | ||
| } | ||
| clientSecret, ok := os.LookupEnv("AZURE_CLIENT_SECRET") | ||
| if !ok { | ||
| return nil, errors.New("missing AZURE_CLIENT_SECRET key") | ||
| } | ||
| tenantId, ok := os.LookupEnv("AZURE_TENANT_ID") | ||
| if !ok { | ||
| return nil, errors.New("missing AZURE_TENANT_ID key") | ||
| } | ||
| subscriptionId, ok := os.LookupEnv("AZURE_SUBSCRIPTION_ID") | ||
| if !ok { | ||
| return nil, errors.New("missing AZURE_SUBSCRIPTION_ID key") | ||
| } | ||
| config := map[string]interface{}{ | ||
| "module": "azure", | ||
| "metricsets": []string{"container_instance"}, | ||
| "client_id": clientId, | ||
| "client_secret": clientSecret, | ||
| "tenant_id": tenantId, | ||
| "subscription_id": subscriptionId, | ||
| } | ||
| return config, nil |
There was a problem hiding this comment.
It seems like there is an opportunity for having some shared code doing this across the board
There was a problem hiding this comment.
that will come with #16754
narph
added a commit
to narph/beats
that referenced
this pull request
Mar 3, 2020
* add container * update changelog * fix test * separate container * separate * regenerate * fixes * tests * fix test (cherry picked from commit d89675f)
narph
added
test-plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should solve #15751
Added
container_service,container_instanceandcontainer_registrymetricsets:Config:
extra config options as in the other metricsets: