Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versioning of dropwizard image used in tests #16332

Merged
merged 5 commits into from
Feb 18, 2020
Merged

Fix versioning of dropwizard image used in tests #16332

merged 5 commits into from
Feb 18, 2020

Conversation

jsoriano
Copy link
Member

What does this PR do?

  • Tag the docker image used for dropwizard tests with the dropwizard metrics version instead of with the maven version used to build it.
  • Use multi staging docker build to build in one image and deploy in another one.
  • Add supported-versions.yml.
  • Test also with 4.1.2.

Why is it important?

  • Uses a more suitable versioning for dropwizard docker images, that can be more easily reused in end to end testing.
  • Previous image was downloading dependencies and building artifacts when run. With this approach everything is pre-built on build time and image directly starts the service when run, so startup is way faster and less error prone.

@jsoriano jsoriano added review refactoring needs_backport PR is waiting to be backported to other branches. :Testing v7.7.0 Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 14, 2020
@jsoriano jsoriano requested a review from a team as a code owner February 14, 2020 13:39
@jsoriano jsoriano self-assigned this Feb 14, 2020
@jsoriano jsoriano mentioned this pull request Feb 14, 2020
Closed
@jsoriano jsoriano merged commit 21e1560 into elastic:master Feb 18, 2020
@jsoriano jsoriano deleted the dropwizard-docker-tests branch February 18, 2020 11:31
@jsoriano jsoriano mentioned this pull request Feb 18, 2020
Merged
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Feb 18, 2020
jsoriano added a commit to jsoriano/beats that referenced this pull request Feb 18, 2020
@jsoriano
Fix versioning of dropwizard image used in tests (elastic#16332)
2900105 
Tag the docker image used for dropwizard tests with the dropwizard
metrics version instead of with the maven version used to build it.
Prebuild artifacts so there is no need to download dependencies
and build when running the immages.
Add supported-versions.yml.
Test also with 4.1.2.

(cherry picked from commit 21e1560)
jsoriano added a commit that referenced this pull request Feb 18, 2020
@jsoriano
Fix versioning of dropwizard image used in tests (#16332) (#16380)
10ecd27 
Tag the docker image used for dropwizard tests with the dropwizard
metrics version instead of with the maven version used to build it.
Prebuild artifacts so there is no need to download dependencies
and build when running the immages.
Add supported-versions.yml.
Test also with 4.1.2.

(cherry picked from commit 21e1560)
kvch pushed a commit to kvch/beats that referenced this pull request Feb 20, 2020
@jsoriano @kvch
Fix versioning of dropwizard image used in tests (elastic#16332)
bfd0631 
Tag the docker image used for dropwizard tests with the dropwizard
metrics version instead of with the maven version used to build it.
Prebuild artifacts so there is no need to download dependencies
and build when running the immages.
Add supported-versions.yml.
Test also with 4.1.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@jsoriano jsoriano

Labels
refactoring review Team:Services (Deprecated) Label for the former Integrations-Services team :Testing v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoriano @mdelapenya @mtojek @andresrc