-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues with versioning of uwsgi in tests #16316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
uwsgi-docker-tests
branch
from
February 13, 2020 18:42
c4bf3ce
to
e3073fe
Compare
mdelapenya
reviewed
Feb 13, 2020
ports: | ||
- 9192 | ||
extends: | ||
service: uwsgi_tcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! 🍬
mdelapenya
approved these changes
Feb 13, 2020
jsoriano
added
the
Team:Services
(Deprecated) Label for the former Integrations-Services team
label
Feb 13, 2020
jsoriano
added
needs_backport
PR is waiting to be backported to other branches.
v7.7.0
labels
Feb 17, 2020
blakerouse
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 18, 2020
Actually use the build arguments in the docker file Add build argument for the UWSGI version Add supported-versions.yml Reuse service definition in docker-compose.yml (cherry picked from commit 34d0c35)
jsoriano
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Feb 18, 2020
jsoriano
added a commit
that referenced
this pull request
Feb 19, 2020
kvch
pushed a commit
to kvch/beats
that referenced
this pull request
Feb 20, 2020
Actually use the build arguments in the docker file Add build argument for the UWSGI version Add supported-versions.yml Reuse service definition in docker-compose.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
refactoring
review
Team:Integrations
Label for the Integrations team
Team:Services
(Deprecated) Label for the former Integrations-Services team
:Testing
v7.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
supported-versions.yml
docker-compose.yml
Why is it important?