Agent/ca sha256 #16217
Merged
Agent/ca sha256 #16217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
added
in progress
|
Pinging @elastic/ingest (Project:fleet) |
|
jenkins test this please |
When you enroll an agent you can specify the `certificate_authorities`, but when you fallback on the OS trust store you may want to be able to check which CA was used to validate the remote server chain this PR allow to define a CASHA256 to validate the remote server. Based on work from elastic#16019
ph
added
review
[zube]: In Review
and removed
in progress
|
@ruflin fyi look at the enrolment command in the description, this is what it will look like. |
|
@michalpristas ready for review. |
michalpristas
approved these changes
Feb 12, 2020
| @@ -97,12 +97,6 @@ func NewConfigFromURL(kURL string, CAs []string) (*Config, error) { | |||
| c.Username = username | |||
| c.Password = password | |||
|
|
|||
| if len(CAs) > 0 { | |||
| c.TLS = &tlscommon.Config{ | |||
| CAs: CAs, | |||
There was a problem hiding this comment.
do we need this option now? we use this to pass CAs as a root CAs to the client. but without having anything to pass i think we can remove it
There was a problem hiding this comment.
There are some case that we will still need to support passing a CAs, but this can done by altering the TLS field after.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Allow to use a ca_sha256 when enroll an Agent When you enroll an agent you can specify the `certificate_authorities`, but when you fallback on the OS trust store you may want to be able to check which CA was used to validate the remote server chain this PR allow to define a CASHA256 to validate the remote server. Based on work from elastic#16019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you enroll an agent you can specify the
certificate_authorities,but when you fall back on the OS trust store you may want to be able to
check which CA was used to validate the remote server chain this PR
allow defining a CASHA256 to validate the remote server.
Based on work from #16019
The enrollment command will look like this.
Fixes: #15718
Fixes: #15716