azure-event hub: improve error handling and stop input if the event has not been processed correctly #16215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narph
added
Filebeat
|
This is great! thank you for looking into it. ey @narph, I'm missing where we return the error that goes up in the chain so EPH detects it. Can you point to it in the code? |
|
This is not implementing e2e ACK, yet it handles the stopping better, as it won't checkpoint documents that haven't been sent. Could you please update changelog & description to describe what the change is doing? e2e is something we still want to implement in the future, let's make sure people don't get confused by this change |
narph
changed the title
exekias
approved these changes
Mar 23, 2020
narph
added a commit
to narph/beats
that referenced
this pull request
Mar 24, 2020
…as not been processed correctly (elastic#16215) * work on GA * update changelog * go vet * work on error * error handling * error message * temp * temp * undo tests * update * integration * fmt update * upgrade * upgrade * mage vendor * notice (cherry picked from commit 1d3bc8c)
narph
added a commit
that referenced
this pull request
Mar 24, 2020
…d stop input if the event has not been processed correctly (#17195) * azure-event hub: improve error handling and stop input if the event has not been processed correctly (#16215) * work on GA * update changelog * go vet * work on error * error handling * error message * temp * temp * undo tests * update * integration * fmt update * upgrade * upgrade * mage vendor * notice (cherry picked from commit 1d3bc8c) * ran mage vendor
narph
added
test-plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with issue #15671
Previously, if the event was not successfully processed, the checkpoint would have still been updated and the input would move to the next set of messages.
compositeHandlersmethod returns nil either way https://github.com/elastic/beats/blob/master/vendor/github.com/Azure/azure-event-hubs-go/v3/eph/eph.go#L406so the checkpoint is updated https://github.com/elastic/beats/blob/master/vendor/github.com/Azure/azure-event-hubs-go/v3/receiver.go#L242.
In the new release 3.1.2 for the azure-event-hub sdk, the error is returned https://github.com/Azure/azure-event-hubs-go/blob/v3.1.2/eph/eph.go#L423 so the checkpoint is not updated anymore.
This is still not e2e ack as this does not stop if the events were not sent to ES.