Cherry-pick #15923 to 7.x: [Metricbeat] Support processors defined for light modules #15992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Adjust test cases first * Setup processors for light modules * Fix: comments, mage check * Adjust code * Fix: missing comment * Fix: mage check * Test light modules * Test connector * Test runner * Fix: ToLower * Adjust code after review * Fix: mage check * Adjust code after review * Adjust code after review * Fix: check error * Fix: imports * Increase test coverage * Add unit tests * Fix: hound * beater: use factory * Beater: modules * Fix: system tests * Fix: implements interface * Add changelog entry * Verify if processors are setup (cherry picked from commit a70d6e8)
kaiyan-sheng
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15923 to 7.x branch. Original message:
This PR adds processor support for light modules. Processors can be enabled using definitions in
manifest.yml.Issue: #14740
Let me start with draft and if we're fine with design and implementation, I will cover it with tests.