Cherry-pick #15946 to 7.x: Remove debug logging from keystore #15969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keystore is loaded before the configuration file is loaded, which means that some debug messages are never printed, because logging is still not initialized (logs will be discarded). (cherry picked from commit 56924a3)
kaiyan-sheng
approved these changes
Jan 30, 2020
kvch
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15946 to 7.x branch. Original message:
What does this PR do?
This changes removes debug logging from the keystore.
Why is it important?
Aim is to remove the need for global logger functions.
I first tried to pass a logger and fix up dependends. But then I realized that the keystore is loaded before the configuration file is loaded. The logging subsystem is only setup once the configuration file is loaded, which means that some debug messages are never printed anyways. Trying to pass a logger into the Keystore will have the keystore use an uninitialized logger.
When unpacking configs debug logs might have been written. These are also removed debug logs. But I don't think removing them is a big loss (debug log was only written if the key was actually found in the keystore...). @ph WDYT?
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs