-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go-ucfg to v0.8.1 release #15937
Conversation
…ault value is zero.
…within the wait_until range.
…ing the default buffer to be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The go-ucfg
entries in vendor/vendor.json
is not updated. Could you please update the dependency using govendor fetch
? This way the NOTICE.txt
file can be updated as well to reflect the versions/revisions we are using at the moment.
I meant updating all entries in the vendor.json, not just the top-level one. For example, github.com/elastic/go-ucfg/cfgutil, github.com/elastic/go-ucfg/flag, etc. Running |
@kvch I have used |
The other packages from |
@kvch updated with govendor done correctly this time |
* Update go-ucfg to v0.8.0. * Update go-ucfg to 0.8.1. * Fix tests with latest go-ucfg. * Fix filebeat x-pack httpjson internal not to be required when the default value is zero. * Fix system test_no_es_connection to ensure that it times out quickly within the wait_until range. * Fix filebeat UDP input config to allow zero in the read buffer, allowing the default buffer to be used. * Fix test_shutdown_wait_timeout to set a low timeout for logstash output. * Fix test_shutdown_wait_timeout to fail instantly by trying to connect to localhost. * Run govendor github.com/elastic/[email protected] * Run make notice. * Add to CHANGELOG.next.asciidoc. * Perform recursive govendor on go-ucfg v0.8.1 and make notice. (cherry picked from commit 73b8518)
* Update go-ucfg to v0.8.0. * Update go-ucfg to 0.8.1. * Fix tests with latest go-ucfg. * Fix filebeat x-pack httpjson internal not to be required when the default value is zero. * Fix system test_no_es_connection to ensure that it times out quickly within the wait_until range. * Fix filebeat UDP input config to allow zero in the read buffer, allowing the default buffer to be used. * Fix test_shutdown_wait_timeout to set a low timeout for logstash output. * Fix test_shutdown_wait_timeout to fail instantly by trying to connect to localhost. * Run govendor github.com/elastic/[email protected] * Run make notice. * Add to CHANGELOG.next.asciidoc. * Perform recursive govendor on go-ucfg v0.8.1 and make notice. (cherry picked from commit 73b8518)
What does this PR do?
Updates the vendored go-ucfg to v0.8.1.
Note: This includes a breaking change that removes the variable substition from environment variables when they are read from the configuration. elastic/go-ucfg#139
Why is it important?
Gets the latest fixes and additions including:
Added
Changed
Fixed
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs