Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.13.7 #15920

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

mikemadden42
Copy link
Contributor

@mikemadden42 mikemadden42 commented Jan 29, 2020

What does this PR do?

go1.13.7 (released 2020/01/28) includes two security fixes to the crypto/x509 package. See the Go 1.13.7 milestone on the issue tracker for details.

Why is it important?

go 1.13.7 fixes two important security issues.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • run beats-ci/package passes

How to test this PR locally

  • make release-manager-release passes
  • make release-manager-snapshot passes

Related issues

Use cases

Screenshots

Logs

@mikemadden42
Copy link
Contributor Author

run beats-ci/package

1 similar comment
@mikemadden42
Copy link
Contributor Author

run beats-ci/package

@ycombinator ycombinator self-assigned this Jan 29, 2020
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mikemadden42
Copy link
Contributor Author

FYI, packaging jobs have been failing for sometime in master with a similar error. master in this case was still using go 1.13.6.

https://beats-ci.elastic.co/job/elastic+beats+master+multijob-package-linux/339/console

13:31:13 package ran for 10m38.708294233s
13:31:13 make[1]: Leaving directory `/var/lib/jenkins/workspace/elastic+beats+master+multijob-package-linux/src/github.com/elastic/beats/x-pack/auditbeat'
13:31:13 make[1]: Entering directory `/var/lib/jenkins/workspace/elastic+beats+master+multijob-package-linux/src/github.com/elastic/beats/x-pack/dockerlogbeat'
13:31:13 mage package
13:31:14 2020/01/29 13:31:14 Found Elastic Beats dir at /var/lib/jenkins/workspace/elastic+beats+master+multijob-package-linux/src/github.com/elastic/beats
13:43:51 Error: runtime error: invalid memory address or nil pointer dereference

@mikemadden42
Copy link
Contributor Author

@mikemadden42
Copy link
Contributor Author

These are the type of errors I'm seeing in the beats-ci/package job:

13:31:03 >> Testing package contents
13:31:13 package ran for 10m38.708294233s
13:31:13 make[1]: Leaving directory `/var/lib/jenkins/workspace/elastic+beats+master+multijob-package-linux/src/github.com/elastic/beats/x-pack/auditbeat'
13:31:13 make[1]: Entering directory `/var/lib/jenkins/workspace/elastic+beats+master+multijob-package-linux/src/github.com/elastic/beats/x-pack/dockerlogbeat'
13:31:13 mage package
13:31:14 2020/01/29 13:31:14 Found Elastic Beats dir at /var/lib/jenkins/workspace/elastic+beats+master+multijob-package-linux/src/github.com/elastic/beats
13:43:51 Error: runtime error: invalid memory address or nil pointer dereference
13:43:51 make[1]: *** [release] Error 1

@mikemadden42
Copy link
Contributor Author

Fix for the nil pointer issue:
#15935

@mikemadden42 mikemadden42 merged commit dbfbf34 into elastic:master Jan 30, 2020
@mikemadden42 mikemadden42 deleted the update-go-1.13.7 branch January 30, 2020 02:38
mikemadden42 added a commit to mikemadden42/beats that referenced this pull request Jan 30, 2020
(cherry picked from commit dbfbf34)
mikemadden42 added a commit to mikemadden42/beats that referenced this pull request Jan 30, 2020
(cherry picked from commit dbfbf34)
mikemadden42 added a commit that referenced this pull request Jan 30, 2020
(cherry picked from commit dbfbf34)
mikemadden42 added a commit that referenced this pull request Jan 30, 2020
(cherry picked from commit dbfbf34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants