Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat: add ELB dashboard #15804

Merged
merged 5 commits into from
Jan 28, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jan 24, 2020

This PR adds missing ELB dashboard.

Issue: #14970

filebeat-aws-elb-overview

@mtojek mtojek requested a review from a team as a code owner January 24, 2020 09:22
@mtojek mtojek added Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. labels Jan 24, 2020
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard is looking good! Just please add a changelog for this.

ps: I'm not so familiar with the spesific metricset to know if data can provide more/different visualisations.

@mtojek
Copy link
Contributor Author

mtojek commented Jan 24, 2020

Dashboard is looking good! Just please add a changelog for this.

ps: I'm not so familiar with the spesific metricset to know if data can provide more/different visualisations.

Thanks! Added.

I'll wait for @kaiyan-sheng to rate this one. I'm open to add more visualizations, but keep in mind that it's already full.

@mtojek mtojek requested a review from kaiyan-sheng January 24, 2020 14:40
@@ -77,6 +77,8 @@ TLS or Beats that accept connections over TLS and validate client certificates.

*Filebeat*
- Set event.outcome field based on googlecloud audit log output. {pull}15731[15731]
- Add dashboard for AWS ELB filebeat module. {pull}15804[15804]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fileset 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@kaiyan-sheng
Copy link
Contributor

Very cool!! Thanks for adding this!! One little thing: could you customize the name of each visualization in the dashboard to remove the duplicate [Filebeat AWS] ECS please?

@mtojek
Copy link
Contributor Author

mtojek commented Jan 27, 2020

Very cool!! Thanks for adding this!! One little thing: could you customize the name of each visualization in the dashboard to remove the duplicate [Filebeat AWS] ECS please?

Done. Also, updated screenshot.

@mtojek mtojek requested a review from kaiyan-sheng January 27, 2020 08:04
@mtojek mtojek merged commit 095c60e into elastic:master Jan 28, 2020
mtojek added a commit to mtojek/beats that referenced this pull request Jan 28, 2020
* Filebeat: add ELB dashboard

* Add CHANGELOG entry

* Fix: changelog

* Update dashboard

* Update screenshot

(cherry picked from commit 095c60e)
@mtojek mtojek added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 28, 2020
mtojek added a commit that referenced this pull request Jan 28, 2020
* Filebeat: add ELB dashboard (#15804)

* Filebeat: add ELB dashboard

* Add CHANGELOG entry

* Fix: changelog

* Update dashboard

* Update screenshot

(cherry picked from commit 095c60e)

* Fix: CHANGELOG
mtojek added a commit to mtojek/beats that referenced this pull request Feb 3, 2020
* Filebeat: add ELB dashboard

* Add CHANGELOG entry

* Fix: changelog

* Update dashboard

* Update screenshot

(cherry picked from commit 095c60e)
@mtojek mtojek added the v7.6.0 label Feb 3, 2020
mtojek added a commit that referenced this pull request Feb 3, 2020
* Filebeat: add ELB dashboard (#15804)

* Filebeat: add ELB dashboard

* Add CHANGELOG entry

* Fix: changelog

* Update dashboard

* Update screenshot

(cherry picked from commit 095c60e)

* Fix: changelog
@mtojek mtojek added the test-plan Add this PR to be manual test plan label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat test-plan Add this PR to be manual test plan v7.6.0 v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants