Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat][Istio] Add mixer metricset #15696

Merged
merged 8 commits into from
Jan 24, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 21, 2020

This PR adds mixer metricset for istio Module.

The metrics will be collected from the respective Prometheus exporter endpoint:
istio-telemetry.istio-system:15014: The istio-telemetry job returns all Mixer-specific metrics. Use this endpoint to monitor Mixer itself.

Part of: #15505

Manual testing

  1. Build or download x-pack metricbeat executable
  2. Spin up a Kubernetes cluster with Minikube
  3. Install ISTIO https://istio.io/docs/setup/install/
  4. Expose the istio-telemetry.istio-system:15014 service to working machine, using kubectl port-forward, kubectl -n istio-system port-forward svc/istio-telemetry 15014:15014
  5. Enable the istio module, configure it in metricbeat.yaml and start monitoring ISTIO mixer

@ChrsMark ChrsMark added enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Jan 21, 2020
@ChrsMark ChrsMark requested a review from a team as a code owner January 21, 2020 12:50
@ChrsMark ChrsMark self-assigned this Jan 21, 2020
@ChrsMark ChrsMark mentioned this pull request Jan 21, 2020
11 tasks
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a mage update issue with [metricbeat/docs/modules/istio.asciidoc] ?

@ChrsMark ChrsMark requested a review from a team January 23, 2020 09:36
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a couple of minor comments.

CHANGELOG.next.asciidoc Show resolved Hide resolved
@@ -93,6 +93,8 @@ TLS or Beats that accept connections over TLS and validate client certificates.
- Add DynamoDB AWS Metricbeat light module {pull}15097[15097]
- Release elb module as GA. {pull}15485[15485]
- Add a `system/network_summary` metricset {pull}15196[15196]
- Add mesh metricset for Istio Metricbeat module {pull}15535[15535]
- [Metricbeat][Istio] Add mixer metricset {pull}15696[15696]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Metricbeat][Istio] Add mixer metricset {pull}15696[15696]
- Add mixer metricset for Istio Metricbeat module {pull}15696[15696]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrsMark it seems that the line is duplicated now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

metricbeat/docs/modules/istio.asciidoc Outdated Show resolved Hide resolved
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark requested review from AleBElastic and a team and removed request for AleBElastic January 24, 2020 09:52
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Copy link
Member Author

@jsoriano thanks for reviewing! It looks that the fixes are ok now, sorry for any confusion!

@ChrsMark ChrsMark merged commit e05ade8 into elastic:master Jan 24, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Jan 24, 2020
@ChrsMark ChrsMark added the test-plan Add this PR to be manual test plan label Feb 4, 2020
@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat review Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants