-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat][Istio] Add mixer metricset #15696
Conversation
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a mage update
issue with [metricbeat/docs/modules/istio.asciidoc]
?
Signed-off-by: chrismark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a couple of minor comments.
CHANGELOG.next.asciidoc
Outdated
@@ -93,6 +93,8 @@ TLS or Beats that accept connections over TLS and validate client certificates. | |||
- Add DynamoDB AWS Metricbeat light module {pull}15097[15097] | |||
- Release elb module as GA. {pull}15485[15485] | |||
- Add a `system/network_summary` metricset {pull}15196[15196] | |||
- Add mesh metricset for Istio Metricbeat module {pull}15535[15535] | |||
- [Metricbeat][Istio] Add mixer metricset {pull}15696[15696] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Metricbeat][Istio] Add mixer metricset {pull}15696[15696] | |
- Add mixer metricset for Istio Metricbeat module {pull}15696[15696] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrsMark it seems that the line is duplicated now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
@jsoriano thanks for reviewing! It looks that the fixes are ok now, sorry for any confusion! |
(cherry picked from commit e05ade8)
This PR adds mixer metricset for istio Module.
The metrics will be collected from the respective Prometheus exporter endpoint:
istio-telemetry.istio-system:15014: The istio-telemetry job returns all Mixer-specific metrics. Use this endpoint to monitor Mixer itself.
Part of: #15505
Manual testing
kubectl -n istio-system port-forward svc/istio-telemetry 15014:15014
istio
module, configure it in metricbeat.yaml and start monitoring ISTIOmixer