-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the Elastic Logging Plugin to master #15085
Conversation
* init commit of dockerlogbeat
* make locking more fine-grained on client close
* refactor pipeline reader for data safety
… checking (#14523) * shuffle around docker deps due to import path checking
…peration (#14518) * move pipeline check + creation to single atomic operation
* more cleanup * fix godocs and readme
* add a release target, cleanup magefile
* add test and fix copy bug * remove debug lines * add header
Add more integration tests and a mock framework
* add common targets to mage
* Get Travis, Jenkins CI in docker plugin
…at name (#15032) * add strings.Trim to container.name * fix beat name
@fearful-symmetry @dedemorton Do we have any docs planned for this project? |
@urso @dedemorton Docs are on my list on #13990 honestly have No idea where to start with proper asciidocs. |
I told Alex that I would help them set up some skeleton asciidoc files when I get back from vacation in January. I'm planning some structural changes that I want to make in parallel for some stuff that I've been stalled on for awhile. Forgot to add...for now, I think it's OK for Alex to capture some basic docs in a readme file. |
@dedemorton @fearful-symmetry Thanks for the clarification. I guess we can proceed merging the plugin then. |
* Add a docker plugin - Elastic Log Driver (elastic#13761) (cherry picked from commit 4a7a8c3)
See #13990 and #13761
What is this?
This is a new beat that takes the form of a docker plugin for logs. The only release artifact takes the form of a plugin (which is basically a runc container) which lives in a docker repo. Aside from the different release artifacts, this operates under the hood as a normal beat. It uses libbeat, and takes many of the same configuration options as any other beat.
How to test
Once you have the branch checked out, navigate to
x-pack/dockerlogbeat
. Runmage package
on a host with docker to generate the plugin.You can test like this:
I've never merged a new beat to master, so I'm not entirely sure what needs to happen.