Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #14558 to 7.x: Feature/read metrics from unix socket npipe #14721

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 22, 2019

Cherry-pick of PR #14558 to 7.x branch. Original message:

Added more logic inside the metricbeat url parser to differentiate the "http+unix" and the "http+npipe" case. This should not have any impact on any current module and allow to "add" the behavior to the helper.NewHTTP without introducing any breaking changes.

Allow monitoring information from libbeat to be retrieved over unix domain socket and named pipes.

(cherry picked from commit baf8c1d)
@ph ph requested a review from ycombinator November 22, 2019 20:52
@ph ph added the Team:Beats label Nov 22, 2019
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ycombinator
Copy link
Contributor

jenkins, test this.

@ph ph merged commit 80e401a into elastic:7.x Nov 25, 2019
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants