[libbeat] Temporarily vendor sarama from elastic's fork #14716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing, in 1.24.0 zstd support was replaced to use a pure-go implementation, and a regression was introduced (IBM/sarama#1252). I think we don't support this compression algorithm, but we should take this into account in case we want to add support for it, maybe adding a comment in the list of supported algorithms in And we could also remove |
|
Good catch on zstd, though it looks like it's been broken for some time -- I added a note to the code (and removed the old library) |
faec
added
libbeat
needs_backport
jsoriano
approved these changes
Nov 22, 2019
faec
added
v7.5.0
and removed
needs_backport
faec
added a commit
to faec/beats
that referenced
this pull request
Nov 22, 2019
* remove mainline sarama * Vendor sarama from github.com/elastic/[email protected] * Update NOTICE.txt * Add note about sarama zstd breakage * remove github.com/DataDog/zstd from vendor dir as it's now unused (cherry picked from commit f35ffdc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor http://github.com/Shopify/sarama from elastic's fork which includes the Azure fix elastic/sarama@355d120
This was created by: