Update AWS Cloudwatch mappings #14653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS cloudwatch metrics were being reported under `aws.metrics`, but the mapping definitions in `fields.yml` were expecting these under `aws.cloudwatch.metrics`. This change fixes that and refactors how metrics are handled when used together with Lightweight modules. Metrics should now include the metricset name in the path, example: For cloudwatch metricset, metrics look like: ``` aws.cloudwatch.metrics.CPUUtilization.p10 aws.cloudwatch.dimensions.InstanceId ``` While when used from a lightweight module it produces: ``` aws.ebs.metrics.BurstBalance.avg aws.cloudwatch.dimensions.VolumeId ``` I kept dimensions together as sometimes these can be used for correlation, so having them under the same field helps.
exekias
added
in progress
|
I've played with this while thinking on #14662, would love to hear opinions here |
|
Thanks @exekias for starting this! One thing I'm concerned about is the inconsistency of ebs/cloudwatch in light module use case: metrics and dimensions are both concepts from AWS Cloudwatch. It makes sense with metrics from cloudwatch metricset but for light modules, will this difference be confusing a bit? |
|
Sorry you are right, I actually changed them to |
Thanks! I'm good with |
kaiyan-sheng
approved these changes
Dec 6, 2019
This was referenced Dec 16, 2019
[Metrics UI] Add AWS Cloudwatch dimensions to groups filter in Metrics Explorer
elastic/kibana#52646
Closed
|
closing in favor of #15245 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS cloudwatch metrics were being reported under
aws.metrics, but themapping definitions in
fields.ymlwere expecting these underaws.cloudwatch.metrics.This change fixes that and refactors how metrics are handled when used
together with Lightweight modules. Metrics should now include the
metricset name in the path, example:
For cloudwatch metricset, metrics look like:
While when used from a lightweight module it produces:
I kept dimensions together as sometimes these can be used for
correlation, so having them under the same field helps.
TODO: