Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Rename pipeline into stream #14593

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Refactor: Rename pipeline into stream #14593

merged 2 commits into from
Nov 26, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 18, 2019

To align the code base with the multiple output strategy we will rename
the pipeline concept into the streams.

See #14445

@ph
Copy link
Contributor Author

ph commented Nov 20, 2019

jenkins test this please

@ph
Copy link
Contributor Author

ph commented Nov 21, 2019

thats odd all theses conflicts..

@ph
Copy link
Contributor Author

ph commented Nov 21, 2019

lets get that merged. I am working on making the configurations changes work.

@ph ph assigned ph and unassigned ph Nov 21, 2019
@ph ph self-assigned this Nov 22, 2019
@michalpristas
Copy link
Contributor

can you recreate this PR? i find this diff really disturbing. something is off here

@ph
Copy link
Contributor Author

ph commented Nov 25, 2019

You are right, this is weird. let me try to rebase it off a fresh fleet branch.

To align the code base with the multiple output strategy we will rename
the pipeline concept into the streams.

See elastic#14445
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one occurrence sneaked in

x-pack/agent/pkg/agent/application/stream.go Outdated Show resolved Hide resolved
@ph
Copy link
Contributor Author

ph commented Nov 25, 2019

fixed waiting for CI.

@ph ph closed this Nov 26, 2019
@ph ph reopened this Nov 26, 2019
@ph ph merged commit 441bde5 into elastic:fleet Nov 26, 2019
@ph ph deleted the streams branch November 26, 2019 19:40
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Refactor: Rename pipeline into stream

To align the code base with the multiple output strategy we will rename
the pipeline concept into the streams.

See elastic#14445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants