-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] VSphere module dashboards #14135
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
The Travis build is failing with
but I do not know how to fix this. |
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @philippkahr! Great work on this, thank you!
I was able to load the dashboards without a problem! My two points are:
- Could you add an updated screenshot of the dashboards in this PR so as people can comment on the visualisations and propose improvements to make them more meaningful?
- I wonder if it is ok to have 2 different dashboards for this module.
Hi @ChrsMark thanks for reviewing my changes. Sorry for the "typos", maybe we should add a naming scheme and example to the contributions guide?
Sure! I will do that later tonight.
|
Sure! We are currently in discussions about improving the Developer Guides in general. Feel free to open an issue mentioning that proposal. |
Thank you for taking the time to open the issue @philippkahr! We can go on with this PR regardless, so feel free to add screenshot(s) of the dashboards in new comments here so as to verify them and maybe suggest improvements. 🙂 |
I'm very excited to see this in action! My team are very happy with the Infrastructure dashboard. If we can also see the VSphere metrics to, this stack will add so much value to our environment! |
Hi, sorry, it took so long. I had to add a lot of white boxes and some example text since I am using real data. I hope that this is still ok. Metricbeat VSphere Hosts Overview ECSMetricbeat VSphere VMs overview ECSThe heatmap itself is used to show where a VM has been on an ESXi host in the timeframe. This might show you if a VM is likely to be moved around a lot. The other dashboards are self-explanatory, to me at least :). |
A very good view would be a VM distributed by the hosts. Similar to what you see on the Infrastructure tab. This would allow us to quickly identify hosts that could soon become overloaded if we know which VMs will soon have access spikes. |
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Outdated
Show resolved
Hide resolved
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Outdated
Show resolved
Hide resolved
…vsphere-host.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-vm.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-vm.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-vm.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-host.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-host.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-host.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-vm.json Co-Authored-By: Chris Mark <[email protected]>
…vsphere-vm.json Co-Authored-By: Chris Mark <[email protected]>
Hi @ChrsMark can you please double-check if I did the rebase correctly? I am doing this for the first time.
|
Yeah it looks ok, this is the way to go with rebasing. Thank you! |
ok to test |
metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Outdated
Show resolved
Hide resolved
Loaded the dashboards successfully. Found one left-over on one of the tittles. After that I think we are ok to merge. |
…vsphere-vm.json Co-Authored-By: Chris Mark <[email protected]>
ok to test |
Failing tests, seem to be irrelevant. Merging. Thank you so much for contributing this @philippkahr 🙂 ! |
(cherry picked from commit fae0e6e)
Hi,
I created some dashboards for the VSphere module.
#14101