Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] VSphere module dashboards #14135

Merged
merged 22 commits into from
Nov 6, 2019
Merged

[Metricbeat] VSphere module dashboards #14135

merged 22 commits into from
Nov 6, 2019

Conversation

philippkahr
Copy link
Contributor

Hi,

I created some dashboards for the VSphere module.

#14101

@philippkahr philippkahr requested a review from a team as a code owner October 18, 2019 16:23
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@philippkahr philippkahr changed the title [metricbeat] vsphere module dashboards cherry-picks https://github.com/elastic/beats/commit/5240ac8e4451fccbcfe5b1d8f50a4a6224e120e6 [metricbeat] vsphere module dashboards cherry-picks 5240ac8 Oct 18, 2019
@philippkahr
Copy link
Contributor Author

The Travis build is failing with

Get the licenses available from ['./vendor', './metricbeat/vendor', './metricbeat/module/kvm/vendor', './metricbeat/module/postgresql/vendor', './metricbeat/module/vsphere/vendor', './metricbeat/module/mysql/vendor']

but I do not know how to fix this.

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @philippkahr! Great work on this, thank you!

I was able to load the dashboards without a problem! My two points are:

  1. Could you add an updated screenshot of the dashboards in this PR so as people can comment on the visualisations and propose improvements to make them more meaningful?
  2. I wonder if it is ok to have 2 different dashboards for this module.

@philippkahr
Copy link
Contributor Author

Hi @ChrsMark

thanks for reviewing my changes. Sorry for the "typos", maybe we should add a naming scheme and example to the contributions guide?

  1. Could you add an updated screenshot of the dashboards in this PR so as people can comment on the visualizations and propose improvements to make them more meaningful?

Sure! I will do that later tonight.

  1. I wonder if it is ok to have 2 different dashboards for this module.
    Hmm, that depends really. I think the first dashboard is really for the cluster and hosts. The other one is a drill down into the stats of the virtual machine. Combining those would not make much sense.

@ChrsMark
Copy link
Member

Hi @ChrsMark

thanks for reviewing my changes. Sorry for the "typos", maybe we should add a naming scheme and example to the contributions guide?

Sure! We are currently in discussions about improving the Developer Guides in general. Feel free to open an issue mentioning that proposal.

@ChrsMark
Copy link
Member

Thank you for taking the time to open the issue @philippkahr!

We can go on with this PR regardless, so feel free to add screenshot(s) of the dashboards in new comments here so as to verify them and maybe suggest improvements. 🙂

@Jarzamendia
Copy link

I'm very excited to see this in action! My team are very happy with the Infrastructure dashboard. If we can also see the VSphere metrics to, this stack will add so much value to our environment!

@philippkahr
Copy link
Contributor Author

Hi,

sorry, it took so long.

I had to add a lot of white boxes and some example text since I am using real data. I hope that this is still ok.

Metricbeat VSphere Hosts Overview ECS

Metricbeat VSphere  Hosts Overview ECS

Metricbeat VSphere VMs overview ECS

Metricbeat VSphere  VMs overview ECS

The heatmap itself is used to show where a VM has been on an ESXi host in the timeframe. This might show you if a VM is likely to be moved around a lot. The other dashboards are self-explanatory, to me at least :).

@Jarzamendia
Copy link

A very good view would be a VM distributed by the hosts. Similar to what you see on the Infrastructure tab. This would allow us to quickly identify hosts that could soon become overloaded if we know which VMs will soon have access spikes.

philippkahr and others added 11 commits November 1, 2019 17:38
@philippkahr
Copy link
Contributor Author

Hi @ChrsMark

can you please double-check if I did the rebase correctly? I am doing this for the first time.

inside the vspheredashboard branch from my forked repo
$ git remote -v

origin  [email protected]:philippkahr/beats.git (fetch)
origin  [email protected]:philippkahr/beats.git (push)
upstream        https://github.com/elastic/beats.git (fetch)
upstream        https://github.com/elastic/beats.git (push) 

$ git rebase upstream/master

First, rewinding head to replay your work on top of it...
Applying: https://github.com/elastic/beats/issues/14101 renamed everything according to xyz [metricbeat] ECS, imported and exported the dashboards, created the module.yml
Applying: https://github.com/elastic/beats/pull/14135 added dashboard
Applying: https://github.com/elastic/beats/pull/14135 trying to fix the error from travis ci
Applying: https://github.com/elastic/beats/pull/14135 fixing naming pattern missmatch
Applying: https://github.com/elastic/beats/pull/14135: fixed: empty description, fixed: expected title with format 'Some title [Metricbeat Module]'
Applying: https://github.com/elastic/beats/pull/14135: travis told me to run `Error: some files are not up-to-date. Run 'mage fmt update' then review and commit the changes. Modified: [metricbeat/docs/modules_list.asciidoc]`
Applying: https://github.com/elastic/beats/pull/14135 Remove submodule beats from vendor
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: https://github.com/elastic/beats/pull/14135 added the vsphere dashboards to the docs
Applying: make update

$ git push -f origin vspheredashboards 

Enumerating objects: 211, done.
Counting objects: 100% (211/211), done.
Delta compression using up to 8 threads
Compressing objects: 100% (161/161), done.
Writing objects: 100% (197/197), 1.78 MiB | 2.33 MiB/s, done.
Total 197 (delta 138), reused 10 (delta 3)
remote: Resolving deltas: 100% (138/138), completed with 13 local objects.
To github.com:philippkahr/beats.git
 + 13de30c44...41c36d5a3 vspheredashboards -> vspheredashboards (forced update)

@ChrsMark
Copy link
Member

ChrsMark commented Nov 5, 2019

Hi @ChrsMark

can you please double-check if I did the rebase correctly? I am doing this for the first time.

inside the vspheredashboard branch from my forked repo
$ git remote -v

origin  [email protected]:philippkahr/beats.git (fetch)
origin  [email protected]:philippkahr/beats.git (push)
upstream        https://github.com/elastic/beats.git (fetch)
upstream        https://github.com/elastic/beats.git (push) 

$ git rebase upstream/master

First, rewinding head to replay your work on top of it...
Applying: https://github.com/elastic/beats/issues/14101 renamed everything according to xyz [metricbeat] ECS, imported and exported the dashboards, created the module.yml
Applying: https://github.com/elastic/beats/pull/14135 added dashboard
Applying: https://github.com/elastic/beats/pull/14135 trying to fix the error from travis ci
Applying: https://github.com/elastic/beats/pull/14135 fixing naming pattern missmatch
Applying: https://github.com/elastic/beats/pull/14135: fixed: empty description, fixed: expected title with format 'Some title [Metricbeat Module]'
Applying: https://github.com/elastic/beats/pull/14135: travis told me to run `Error: some files are not up-to-date. Run 'mage fmt update' then review and commit the changes. Modified: [metricbeat/docs/modules_list.asciidoc]`
Applying: https://github.com/elastic/beats/pull/14135 Remove submodule beats from vendor
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-host.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: Update metricbeat/module/vsphere/_meta/kibana/7/dashboard/metricbeat-vsphere-vm.json
Applying: https://github.com/elastic/beats/pull/14135 added the vsphere dashboards to the docs
Applying: make update

$ git push -f origin vspheredashboards 

Enumerating objects: 211, done.
Counting objects: 100% (211/211), done.
Delta compression using up to 8 threads
Compressing objects: 100% (161/161), done.
Writing objects: 100% (197/197), 1.78 MiB | 2.33 MiB/s, done.
Total 197 (delta 138), reused 10 (delta 3)
remote: Resolving deltas: 100% (138/138), completed with 13 local objects.
To github.com:philippkahr/beats.git
 + 13de30c44...41c36d5a3 vspheredashboards -> vspheredashboards (forced update)

Yeah it looks ok, this is the way to go with rebasing. Thank you!

@ChrsMark
Copy link
Member

ChrsMark commented Nov 5, 2019

ok to test

@ChrsMark
Copy link
Member

ChrsMark commented Nov 5, 2019

Loaded the dashboards successfully. Found one left-over on one of the tittles.

After that I think we are ok to merge.

@ChrsMark
Copy link
Member

ChrsMark commented Nov 6, 2019

ok to test

@ChrsMark
Copy link
Member

ChrsMark commented Nov 6, 2019

Failing tests, seem to be irrelevant. Merging.

Thank you so much for contributing this @philippkahr 🙂 !

@ChrsMark ChrsMark merged commit fae0e6e into elastic:master Nov 6, 2019
@philippkahr philippkahr deleted the vspheredashboards branch November 8, 2019 07:59
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request Feb 26, 2020
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants