[Filebeat] Fix s3 access key grok pattern #13811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
Team:Integrations
|
@jsoriano Do I need a changelog for this? 😬 |
Yes please, as this fixes something already released. |
We talked on slack and decide to not put a changelog for this PR unless this didn't get in before 7.4.0. |
kaiyan-sheng
added a commit
that referenced
this pull request
Sep 26, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) (cherry picked from commit dddd34d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing, one more log message showed error with current grok pattern, specifically on
s3access.key. This PR is to fix it.This PR also added some extra error handling when file doesn't exist anymore in s3 bucket or cannot be read.