Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Improve error message in prom collector #13749

Merged
merged 1 commit into from
Sep 20, 2019
Merged

[Metricbeat] Improve error message in prom collector #13749

merged 1 commit into from
Sep 20, 2019

Conversation

fearful-symmetry
Copy link
Contributor

This adds errors.Wrap to the collector so that a parse failure returns the reason for the failure.

@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Sep 20, 2019
@fearful-symmetry fearful-symmetry requested review from a team September 20, 2019 15:13
@fearful-symmetry fearful-symmetry self-assigned this Sep 20, 2019
@fearful-symmetry fearful-symmetry merged commit f12feeb into elastic:master Sep 20, 2019
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Sep 20, 2019
@fearful-symmetry @jsoriano
improve error message in prom collector (elastic#13749)
b2fb2d7
@urso urso added the v7.5.0 label Oct 22, 2019
@jsoriano jsoriano mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees

@fearful-symmetry fearful-symmetry

Labels
Team:Integrations Label for the Integrations team v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fearful-symmetry @jsoriano @kaiyan-sheng @urso